Choose the higher gasLimit and gasPrice in the modal #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessgusclark
changed the title
jessgusclark
changed the title
ilanolkies
requested changes
Dec 5, 2021
| const gasLimitEstimate = wallet.smartWallet | ||
| .estimateDirectExecute(tx.to || '0x', tx.data || '0x') | ||
| .then((estimate: BigNumber) => { | ||
| if (tx.gasLimit && estimate.toNumber() < tx.gasLimit) { |
There was a problem hiding this comment.
Suggested change
| if (tx.gasLimit && estimate.toNumber() < tx.gasLimit) { | |
| if (tx.gasLimit && estimate.lt(tx.gasLimit)) { |
| ?.getGasPrice() | ||
| .then((gp: BigNumber) => gp.mul('101').div('100')) | ||
| .then((estimate: BigNumber) => { | ||
| if (tx.gasPrice && estimate.toNumber() < tx.gasPrice) { |
There was a problem hiding this comment.
Suggested change
| if (tx.gasPrice && estimate.toNumber() < tx.gasPrice) { | |
| if (tx.gasPrice && estimate.lt(tx.gasPrice)) { |
ilanolkies
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
It accomplishes these things by a custom hook that handles all three promises and the state of the gas. This moves the logic outside of the component so it is easier to read and can be reused in the future if needed.
Tests were updated to fix all issues with
act/await/async/etc...