US-2150: Developers need an easy way to change the colors of the wallet #908
Conversation
rodrigoncalves
changed the title
There was a problem hiding this comment.
A few things still need to be solved. And as a suggestion for testing purposes, create a .env variable to switch colors for testing purposes something like theme: "dark" | "light". And choosing this when exporting sharedColors and assign one of two objects. This wasy @jormelCoin can test the actual behaviour and make sure the styles update correctly all over the app.
| @@ -86,7 +86,7 @@ | |||
| "react-native-screens": "^3.29.0", | |||
| "react-native-screenshot-prevent": "^1.1.9", | |||
| "react-native-ssl-public-key-pinning": "^1.1.3", | |||
| "react-native-svg": "^14.1.0", | |||
| "react-native-svg": "13.4.0", | |||
There was a problem hiding this comment.
Wait! Why downgrading?
There was a problem hiding this comment.
I had to downgrade this version to fix an issue with the appearance of the loading screen using a light background.
There was a problem hiding this comment.
@rodrigoncalves can you comment or add screenshot/link to show what issue is being caused by downgrading this library?
There was a problem hiding this comment.
| <Typography | ||
| type={'body3'} | ||
| style={styles.footerText} | ||
| color={sharedColors.white}> |
There was a problem hiding this comment.
Isn't it supposed to be like shared.text.primary?
There was a problem hiding this comment.
No, this is the onboard screen. This screen should be the same for all diferent themes because we're using an image in background.
src/screens/walletConnect/index.tsx
Outdated
| @@ -25,6 +24,7 @@ import { castStyle } from 'shared/utils' | |||
| import { changeTopColor } from 'store/slices/settingsSlice' | |||
| import { useAppDispatch } from 'store/storeUtils' | |||
| import { WalletContext } from 'shared/wallet' | |||
| import NoDappsImage from 'components/icons/NoDappsImage' | |||
| version "14.1.0" | ||
| resolved "https://registry.yarnpkg.com/react-native-svg/-/react-native-svg-14.1.0.tgz#7903bddd3c71bf3a8a503918253c839e6edaa724" | ||
| integrity sha512-HeseElmEk+AXGwFZl3h56s0LtYD9HyGdrpg8yd9QM26X+d7kjETrRQ9vCjtxuT5dCZEIQ5uggU1dQhzasnsCWA== | ||
| react-native-svg@13.4.0: |
There was a problem hiding this comment.
Please, keep newest version
There was a problem hiding this comment.
This was necessary.
Hey @TravellerOnTheRun, I set the var in the .env as you mentioned, but when I put the light option, I didn't see any difference. Please let me know if I put it correctly. On the other side, I called my attention to the white border on some buttons. I'm conscious that it's a minor issue, but I don't know I see a little different. were these modified intentionally? 
|
This has not yet been implemented. |
I assume that will be implemented in another ticket? if so, I think this ticket is working well. |
No description provided.