Ipv6 bootnodes #138
Merged
Ipv6 bootnodes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juli
approved these changes
Jul 13, 2017
| public class IpUtils { | ||
| private static final Logger logger = LoggerFactory.getLogger(IpUtils.class); | ||
|
|
||
| private static final String IPV6_INPUT_FORMAT = "^\\[(.*)\\]:([0-9]{1,})"; |
There was a problem hiding this comment.
- Square brackets are not mandatory for IPv6 addresses if they are not part of an URL or if a port number is not specified. But if there won't be a default port for nodes then it is correct.
- Second group of regex for port number could limit to 5 digits and allow IPs without port
|
|
||
| private static final String IPV6_WITH_PORT = "[2001:db8:85a3:8d3:1319:8a2e:370:7348]:443"; | ||
| private static final String IPV6_NO_PORT = "[2001:db8:85a3:8d3:1319:8a2e:370:7348]"; | ||
| private static final String IPV6_INVALID = "2001:db8:85a3:8d3:1319:8a2e:370:7348"; |
There was a problem hiding this comment.
This IPv6 address is valid if square brackets are not mandatory.
donequis
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.