Build Block Blooms Database (2.2.0) #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patogallaiovlabs
previously requested changes
Dec 11, 2020
ajlopezrsk
force-pushed
the
buildblooms-2.2.0
branch
from
240dde7
to
9e739b2
Compare
|
pipeline:run |
|
Done
|
ajlopezrsk
force-pushed
the
buildblooms-2.2.0
branch
from
cbd7cab
to
4f4631f
Compare
|
pipeline: run |
ajlopezrsk
force-pushed
the
buildblooms-2.2.0
branch
from
4f4631f
to
5809896
Compare
Already done |
ajlopezrsk
force-pushed
the
buildblooms-2.2.0
branch
2 times, most recently
from
06c311c
to
6443014
Compare
…oom method to addBlocksBloom; rename blocksBloom private variable to blocksBloomCache
…g visibility for testing; use HashMap instead of ConcurrentHashMap
…esent in 2.2.0-rc)
ajlopezrsk
force-pushed
the
buildblooms-2.2.0
branch
from
6443014
to
11dc6b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
pipeline: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fit: 2.2-rc
Description
Using a new configuration option, the build and save of block blooms data could be executed within the normal operation of the node. This data is used to retrieve log information efficiently.
Motivation and Context
Usually, this block blooms information is used only in nodes that has JSON RPC open, and log query operation enabled. And with the first query, the data is build and saved. But even with this feature, the operation could take many minutes and resources from the node.
So, this new code allow the build of the same data along the blockchain node normal processing, ie, during long synchronization or normal synchronization. To do this, a new internal service was added, and it is activated by configuration (the default value is not activated),
How Has This Been Tested?
It has code tests, and also was tested running a long sync against testnet network,
Types of changes
Checklist: