Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_syncing fix #1618

Merged
merged 4 commits into from Nov 10, 2021
Merged

eth_syncing fix #1618

merged 4 commits into from Nov 10, 2021

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Sep 28, 2021 •
edited

Description

eth_syncing is returning a boolean indicating if it is syncing or not. However, the returned value is now in relation to the chunk is syncing, so it returns false when the chunk is not being synced.

Motivation and Context

To return false after the node is fully synced

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

fed:eth-syncing-fix

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Sep 28, 2021

pipeline:run

heitorfm
heitorfm previously approved these changes Oct 13, 2021
View reviewed changes
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 8, 2021

pipeline:run

2 similar comments
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 8, 2021

pipeline:run

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 8, 2021

pipeline:run

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 9, 2021

pipeline:run

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@Vovchyk Vovchyk requested a review from heitorfm November 9, 2021 16:04
@Vovchyk Vovchyk merged commit bfce571 into master Nov 10, 2021
@Vovchyk Vovchyk deleted the eth-syncing-fix branch November 10, 2021 07:41
@aeidelman aeidelman added this to the Iris v3.2.0 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorfm heitorfm heitorfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iris 3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vovchyk @heitorfm @aeidelman