Enable cache.states.persist-snapshot feature flag by default

[Vovchyk]

Description

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[illuque-iov]

Hey @Vovchyk, just for you to know: if we enable this by default, it will not work OOTB on Dockerized RSKj, we would need to fix the java.io.File#renameTo usage in CacheSnapshotHandler first for it to work on Docker.

[Vovchyk]

Hey @Vovchyk, just for you to know: if we enable this by default, it will not work OOTB on Dockerized RSKj, we would need to fix the java.io.File#renameTo usage in CacheSnapshotHandler first for it to work on Docker.

hey @illuque-iov , could you please elaborate more on your comment? What needs to be fixed?

[illuque-iov]

Sure, let me explain: java.io.File#renameTo may not work fine in Docker depending on how you setup volumes, etc., check Javadoc. I've faced this issue myself. Using java.io.File#renameTo should be enough according to some quick tests I've performed.

[Vovchyk]

Sure, let me explain: java.io.File#renameTo may not work fine in Docker depending on how you setup volumes, etc., check Javadoc. I've faced this issue myself. Using java.io.File#renameTo should be enough according to some quick tests I've performed.

I see. Let's investigate this issue separately. Looks like it's not docker specific

[Vovchyk]

Sure, let me explain: java.io.File#renameTo may not work fine in Docker depending on how you setup volumes, etc., check Javadoc. I've faced this issue myself. Using java.io.File#renameTo should be enough according to some quick tests I've performed.

I see. Let's investigate this issue separately. Looks like it's not docker specific

I was able to reproduce the issue with external mounted volumes in a docker container. Updated PR accordingly. Nice catch @illuque-iov 👍🏻

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

66.7% Coverage
0.0% Duplication

[Vovchyk]

pipeline:run