Fix response format on eth_hashrate() #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pipeline:run |
|
will be adding unit tests today |
|
Kudos, SonarCloud Quality Gate passed! |
Vovchyk
approved these changes
Jul 18, 2023
|
pipeline:run |
casiojapi
force-pushed
the
fix-eth-hashrate-format
branch
from
8853c8e
to
d51dc61
Compare
casiojapi
force-pushed
the
fix-eth-hashrate-format
branch
from
d51dc61
to
ce7b8e8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the response of the
eth_hashratemethod from a plain decimal number to a hexadecimal string. The change is in line with the behavior of the Geth.Motivation and Context
This change is required to align the behavior of the RSKj client with the Ethereum clients, which return the hashrate as a hex-encoded string. This change fixes issue #1837, where the
eth_hashratemethod in RSKj was returning a plain decimal number.How Has This Been Tested?
The changes have been tested by running the RSKj node with the changes applied. I checked the response format of the
eth_hashratemethod, and it now returns the hashrate as a hex-encoded string, which aligns with the behavior of geth.Types of changes
Checklist: