Update methods argument classes #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Vovchyk
requested changes
Sep 12, 2023
| @@ -5,6 +5,10 @@ | |||
|
|
|||
| public abstract class HexStringParam { | |||
| HexStringParam(String hexString) { | |||
| if(hexString.isEmpty()) { | |||
There was a problem hiding this comment.
should we check if it's null?
There was a problem hiding this comment.
Sure, I will add that.
| @@ -5,6 +5,10 @@ | |||
|
|
|||
| public abstract class HexStringParam { | |||
| HexStringParam(String hexString) { | |||
| if(hexString.isEmpty()) { | |||
| return; | |||
There was a problem hiding this comment.
should we throw an error instead if it's null or empty?
There was a problem hiding this comment.
I left that behevior to the other classes that extends from this one, like HexDurationParam, which should not throw an error if the value is null since the methods using them behave different depending on that.
Vovchyk
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating arguments types for methods listed on CORE-3130
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: