Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update methods arguments types #2132

Merged
merged 2 commits into from Sep 15, 2023
Merged

Update methods arguments types #2132

merged 2 commits into from Sep 15, 2023

Conversation

rmoreliovlabs
Copy link
Contributor

Description

Updating arguments types for methods listed on CORE-3238

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.7% 94.7% Coverage
0.0% 0.0% Duplication

@Vovchyk Vovchyk merged commit 35df451 into json_rpc_param_validation Sep 15, 2023
6 checks passed
@Vovchyk Vovchyk deleted the json_rpc_param_validation_pt5 branch September 15, 2023 08:22
@aeidelman aeidelman added this to the Fingerroot 5.4.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vovchyk Vovchyk Vovchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Fingerroot 5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmoreliovlabs @Vovchyk @aeidelman