Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return properly encoded value by eth_getStorageAt RPC method for non-existing keys #2229

Merged
merged 1 commit into from Jan 18, 2024

Conversation

casiojapi
Copy link
Contributor

Description

Updated eth_getStorageAt to return a 32-byte zero value for non-existing keys, aligning with geth client behavior.

Motivation and Context

Ensures compatibility with Ethers.js and other clients like Geth, which expect a 32-byte zero value for non-existing keys.

How Has This Been Tested?

Tested in local development environment; unit tests updated to reflect new return value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

Copy link

sonarcloud bot commented Jan 17, 2024

@Vovchyk Vovchyk merged commit 12fdadd into master Jan 18, 2024
10 checks passed
@Vovchyk Vovchyk deleted the fix-eth-get-storage-at-encoded-redo branch January 18, 2024 16:34
@aeidelman aeidelman added this to the Fingerroot 5.4.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants