Fixed block ref param handling in eth_call #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoto-iov
reviewed
Apr 1, 2024
| @@ -47,8 +47,11 @@ default String eth_sign(HexAddressParam addr, HexDataParam data) { | |||
| return getEthModule().sign(addr.getAddress().toHexString(), data.getAsHexString()); | |||
| } | |||
|
|
|||
| default String eth_call(CallArgumentsParam args, BlockIdentifierParam bnOrId) { | |||
| return getEthModule().call(args, bnOrId); | |||
| default String eth_call(CallArgumentsParam args, BlockRefParam blockRefParam) { | |||
There was a problem hiding this comment.
As we are updating this method, is there a reason to implement this logic into the interface using default? our could we move the method implementation to the implementation class?
There was a problem hiding this comment.
the idea was to make it as minimalistic as possible. But yeah, in future we may want to refactor this a bit and move all implementations of default methods to appropriate impl classes
Vovchyk
force-pushed
the
eth-call-block-ref-param-fix
branch
from
a0af5bf
to
601a9f9
Compare
|
asoto-iov
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: