Gas exactimation #990
Open
Gas exactimation #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pipeline: run |
|
@SergioDemianLerner this is already in master, isn't it? Done in scope of #1548. Can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete gas exactimation for RSK without the EIP150 1/64th CALL pre-deposit. It doesn't require binary search. A simple computation test was added.
The exactimation works as long as the code called is not malicious (do not use the GAS opcode to perform arbitrary actions based on its value)
This PR still needs some real-world test, however this exactimation CANNOT be worse than the previous implementation, because this one always returns a higher value than the previous one.