Feat: add no-setter-return #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
commented
Sep 26, 2020
xtask/src/docgen/extract.rs
Outdated
Comment on lines
207
to
209
| // If there is a trailing comma, consumes it. | ||
| let _ = input.parse::<Token!(,)>(); | ||
|
|
There was a problem hiding this comment.
This change is related to #5, required to run cargo xtask docgen on rule_test! containing trailing comma.
RDambrosio016
added
C-enhancement
RDambrosio016
requested changes
Sep 26, 2020
10 tasks
|
@RDambrosio016 thanks for the detailed review! Addressed all the points. Please check again :) |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
no-setter-returnrule, requested in #4Please merge this PR after #6, because some test cases cannot be passed without #6.