New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Classification #102
Component Classification #102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 38.76% 40.60% +1.84%
==========================================
Files 51 46 -5
Lines 908 857 -51
Branches 206 191 -15
==========================================
- Hits 352 348 -4
+ Misses 556 509 -47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments for cleanup, but thanks for getting this together 👍
@alexgetty @phess101 Looks like all of my comments have been resolved, but the build is failing. I've pulled down your fork and the same error is occurring for me locally, so it doesn't seem to be an issue with the CI environment. None of the changes were to either of the components referenced ( |
@phess101 / @alexgetty just a heads up, the |
@all-contributors add @phess101 for maintenance |
I've put up a pull request to add @phess101! 🎉 |
@all-contributors add @alexgetty for maintenance |
I've put up a pull request to add @alexgetty! 🎉 |
This PR incorporates Issue #84, which reclassifies numerous Atoms as Molecules based on their HTML structure. All Atoms with more than 1 HTML element, with the exception of icons and wrappers for icon positioning, have been moved to the Molecules layer. Additionally, there were a handful of icon-variant components that were merged into their base component with the ability to optionally add an icon prop.