Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill tests for zip module #90

Open
brandongregoryscott opened this issue Aug 6, 2020 · 0 comments
Open

Backfill tests for zip module #90

brandongregoryscott opened this issue Aug 6, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support hacktoberfest (not required to get credit)

Comments

@brandongregoryscott
Copy link
Contributor

Backfill tests for zip module

As a general rule of thumb, I like to test exit paths (error or otherwise) to ensure the module is killing the process when expected. If we are returning from an erroneous exec or spawnSync call , ensure we are forwarding the exit code properly. (See dotnet-build.test.js for an example of this)

Add coverage where you see the most value - Jest will usually mark description() functions as having missed coverage, but seeing as we only use these for printing out text to the UI help menu, there's little value in testing that.
@brandongregoryscott brandongregoryscott added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2020
@brandongregoryscott brandongregoryscott added the hacktoberfest Support hacktoberfest (not required to get credit) label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support hacktoberfest (not required to get credit)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandongregoryscott