-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case sensitive or not? #35
Comments
flag for 3.1.6? |
Yes. I think so |
If we want to follow semantic versioning, the next version should be called 4.0 if it includes breaking changes. |
We're changing this to case sensitive. |
I'm closing this. Feel free to open this issue again if you have any feedback on the draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Section https://github.com/rsmp-nordic/rsmp_core/blob/master/rst/rsmp.rst#basic-structure states:
I think this is too weak. We should be clear about whether parsing should be case sensitive or insensitive. Errors can arise if systems don't agree.
It's also not clear to me whether this means you're allowed to send commands with different casing. Is 'status', 'Status', and 'STATUS' all allowed? I don't think they should be, I think we should enforce a specific casing.
Unfortunately, casing does not currently seem very consistent, e.g. look at these fields from the example at https://github.com/rsmp-nordic/rsmp_core/blob/master/rst/rsmp.rst#message-structure:
It's a rather confusing combination of casing and spacing.
The text was updated successfully, but these errors were encountered: