Support for MS-MPI and Windows #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the MS-MPI implementation, primarily targeting Windows. I add some code to discover for MS-MPI that only run on Windows, and moved the other MPI probing to a separate probe function for Unix. I inject an msmpi cfg into both mpi-sys and rsmpi. This may be useful to either surface msmpi specifically functionality or, like I do in this commit, to disable certain features that are missing from MS-MPI. I noticed two issues when building with the MS-MPI headers: 1. MPI_Comm_create_group was missing. 2. Bindgen does not seem to pick up the MPI_User_function definition For both of these issues, I just removed the APIs that called these functions when using MS-MPI. This may not be the best method. I also disabled portions of any tests that rely on these functionalities. I recommend building without default features on Windows since libffi is not available by default. I also swapped the gcc crate with cc, as that seems to be the stable version of gcc.
AndrewGaspar
commented
Sep 26, 2018
| // Adds a cfg to identify MS-MPI | ||
| println!("cargo:rustc-cfg=msmpi"); | ||
| } else { | ||
| env::set_var("CC", "mpicc"); |
There was a problem hiding this comment.
I'm wondering if it would make sense to use the Windows methodology here for all platforms. I believe this is what, for example, FindMPI in CMake does - it doesn't actually compile your program with mpicc, It just uses the compile line from mpicc -show. This has the benefit of being able to use your preferred compiler without having to install an MPI on top of each compiler you'd like to use.
I don't know if the Windows version of this is quite robust enough, though. We'd probably need defines, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the MS-MPI implementation, primarily targeting Windows. I add some code to discover for MS-MPI that only run on Windows, and moved the other MPI probing to a separate probe function for Unix.
I inject an msmpi cfg into both mpi-sys and rsmpi. This may be useful to either surface msmpi specifically functionality or, like I do in this commit, to disable certain features that are missing from MS-MPI.
I noticed two issues when building with the MS-MPI headers:
For both of these issues, I just removed the APIs that called these functions when using MS-MPI. This may not be the best method.
I also disabled portions of any tests that rely on these functionalities.
I recommend building without default features on Windows since libffi is not available by default.
I also swapped the gcc crate with cc, as that seems to be the stable version of gcc.