Add MPI_Comm_split_type MPI_COMM_TYPE_SHARED function [AMENDED] #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace MPI_COMM_TYPE_SHARED with RSMPI_COMM_TYPE_SHARED Always return a communicator - documentation seems to indicate it will succeed as long as `split_type` is specified Move implementation higher in the file to be "in-order" with specification
zolkko
approved these changes
Aug 10, 2020
|
Sorry, I'm running into issues with the CI. Haven't gotten the chance to look into why it's failing yet. Seems to be an infrastructure issue. |
|
It seems to be failing in master in the same way, so I'm just going to merge and fix in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I addressed some concerns I had with #89. I moved the routine to a different location in the file (roughly sorted by declaration in the standard). I also documented where in the standard
MPI_Comm_split_typeis described. Additionally, I returned justUserCommunicatorrather thanOption<UserCommunicator>- at least by my reading of the standard, ifMPI_COMM_TYPE_SHAREDis specified, a new communicator is always created.MPI_COMM_NULLseems to only be returned if you specifiedMPI_UNDEFINED. Finally, I createdRSMPI_COMM_TYPE_SHARED- some implementations declareMPI_COMM_TYPE_SHAREDusing#definewhich isn't picked up by bindgen.@zolkko - please take a look.