Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered Requests navigation is obscured by window controls #226

Closed
chrismessina opened this issue Nov 19, 2015 · 7 comments
Closed

Filtered Requests navigation is obscured by window controls #226

chrismessina opened this issue Nov 19, 2015 · 7 comments
Assignees
Labels

Comments

@chrismessina
Copy link
Collaborator

Take a look:

screenshot_11_18_15__7_52_pm

It should be possible to hit the "back" arrow...

@davepagurek
Copy link
Contributor

I added a stylesheet that gets injected in #222, I can add a rule in there. Do you know if there's a way to force this view to show up for testing purposes without having actually received a message request that gets filtered?

@chrismessina
Copy link
Collaborator Author

@davepagurek oh man, not sure. All my requests went away. You could try to message me and then I might see your request: facebook.com/chrismessina

@rsms
Copy link
Owner

rsms commented Dec 1, 2015

Interesting. I wonder if there's a way to either:
a. Detect this state and hide the window controls until state is existed, or
b. Manipulate the DOM for this state to move the chevron to the RHS of the zoom window button, which is kind of what #222 does

@chrismessina
Copy link
Collaborator Author

Yeah, the #222 solution seems apropos. Still trying to reproduce the
appearance of this menu!
On Tue, Dec 1, 2015 at 2:02 PM Rasmus notifications@github.com wrote:

Interesting. I wonder if there's a way to either:
a. Detect this state and hide the window controls until state is existed,
or
b. Manipulate the DOM for this state to move the chevron to the RHS of the
zoom window button, which is kind of what #222
#222 does


Reply to this email directly or view it on GitHub
#226 (comment)
.
Untracked with Trackbuster https://trackbuster.com/?sig

@chrismessina
Copy link
Collaborator Author

Ok, got one...!

screenshot_1_10_16__6_07_pm

When I go back, the gear is stuck under the window buttons:

screenshot_1_10_16__6_08_pm

@rsms
Copy link
Owner

rsms commented Feb 9, 2016

Would be happy to accept a patch for this

@rsms
Copy link
Owner

rsms commented Feb 23, 2016

ee5f7c8...cdafa42 should resolve this. Adds a View > Message Requests item to the main menu, hides window controls (in favor for the "back" chevron button) in message requests and filtered messages view, and also correctly hides the gear icon again after navigating back to the "inbox."

@rsms rsms closed this as completed Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants