Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync >= 3.1.0 stats and bytes changes for utils/rsnapreport.pl #95

Closed
wants to merge 2 commits into from
Closed

rsync >= 3.1.0 stats and bytes changes for utils/rsnapreport.pl #95

wants to merge 2 commits into from

Conversation

guikcd
Copy link
Contributor

@guikcd guikcd commented Jul 13, 2015

  • Minimum verbosity to have rsync output is 4
  • Details on "Number of files", change regexp
  • Number of (regular )?files transferred
  • Bytes are now comma separated
  • Provide example lines to handle future rsync changes

- Minimum verbosity to have rsync output is 4
- Number of files is detailed, change regexp
- Number of (regular )?files transferred
- Bytes are now comma separated
- Provide example lines to handle future rsync changes
@donnykurnia
Copy link

Why this important pull-request got ignored?

@sgpinkus
Copy link
Member

sgpinkus commented Feb 1, 2016

This is broken:

[sam@localhost test]$rsnapshot -c rsnapshot.conf sync 2>&1  | /home/sam/tmp/rsnapshot/utils/rsnapreport.pl
Use of uninitialized value $files in formline at /home/sam/tmp/rsnapshot/utils/rsnapreport.pl line 53.
SOURCE                          TOTAL FILES   FILES TRANS      TOTAL MB     MB TRANS   LIST GEN TIME  FILE XFER TIME
--------------------------------------------------------------------------------------------------------------------
/tmp/test/src/a/                                        1          0.00         0.00   0.001 seconds   0.000 seconds
Use of uninitialized value $files in formline at /home/sam/tmp/rsnapshot/utils/rsnapreport.pl line 53.
/tmp/test/src/b/                                        1          0.00         0.00   0.001 seconds   0.000 seconds
Use of uninitialized value $files in formline at /home/sam/tmp/rsnapshot/utils/rsnapreport.pl line 53.
localhost:/tmp/test/src/c                               0          0.00         0.00   0.001 seconds   0.000 seconds
[sam@localhost test]$rsnapshot -c rsnapshot.conf sync 2>&1  | rsnapreport.pl
SOURCE                          TOTAL FILES   FILES TRANS      TOTAL MB     MB TRANS   LIST GEN TIME  FILE XFER TIME
--------------------------------------------------------------------------------------------------------------------
/tmp/test/src/a/                          4             1          0.00         0.00   0.001 seconds   0.000 seconds
/tmp/test/src/b/                          2             1          0.00         0.00   0.001 seconds   0.000 seconds
localhost:/tmp/test/src/c                 4             0          0.00         0.00   0.001 seconds   0.000 seconds

Tested on

[sam@localhost test]$lsb_release -c; rsync --version
Codename:   wheezy
rsync  version 3.0.9  protocol version 30

@sgpinkus
Copy link
Member

Thanks for the PR. Cherry picked and fixed issue in #128. Closed.

@sgpinkus sgpinkus closed this Feb 13, 2016
sgpinkus added a commit that referenced this pull request Feb 19, 2016
Cherry pick #95 (rsnapreport.pl + rsync >= 3.1.0 bug fix) and update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants