Lint fixes for yarpl (#420)

rsocket · May 15, 2017 · 2cea863 · 2cea863
1 parent a9bc269
commit 2cea863
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/experimental/yarpl/include/yarpl/Observable.h b/experimental/yarpl/include/yarpl/Observable.h
@@ -65,7 +65,7 @@ class Observable : public virtual Refcounted {
   template <typename OnSubscribe>
   class FromPublisherOperator : public Observable<T> {
    public:
-    FromPublisherOperator(OnSubscribe&& function)
+    explicit FromPublisherOperator(OnSubscribe&& function)
         : function_(std::move(function)) {}
 
     void subscribe(Reference<Observer<T>> subscriber) override {

diff --git a/experimental/yarpl/include/yarpl/Refcounted.h b/experimental/yarpl/include/yarpl/Refcounted.h
@@ -81,7 +81,7 @@ class Reference {
     inc();
   }
 
-  Reference(Reference&& other) : pointer_(other.pointer_) {
+  Reference(Reference&& other) noexcept : pointer_(other.pointer_) {
     other.pointer_ = nullptr;
   }
 

diff --git a/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h b/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h
@@ -247,7 +247,7 @@ class SubscribeOnOperator : public FlowableOperator<T, T> {
 template <typename T, typename OnSubscribe>
 class FromPublisherOperator : public Flowable<T> {
  public:
-  FromPublisherOperator(OnSubscribe&& function)
+  explicit FromPublisherOperator(OnSubscribe&& function)
       : function_(std::move(function)) {}
 
   void subscribe(Reference<Subscriber<T>> subscriber) override {

diff --git a/experimental/yarpl/include/yarpl/observable/ObservableOperator.h b/experimental/yarpl/include/yarpl/observable/ObservableOperator.h
@@ -224,7 +224,7 @@ class SubscribeOnOperator : public ObservableOperator<T, T> {
 template <typename T, typename OnSubscribe>
 class FromPublisherOperator : public Observable<T> {
  public:
-  FromPublisherOperator(OnSubscribe&& function)
+  explicit FromPublisherOperator(OnSubscribe&& function)
       : function_(std::move(function)) {}
 
   void subscribe(Reference<Observer<T>> subscriber) override {

diff --git a/experimental/yarpl/include/yarpl/observable/Observers.h b/experimental/yarpl/include/yarpl/observable/Observers.h
@@ -73,7 +73,7 @@ class Observers {
   template <typename T, typename Next>
   class Base : public Observer<T> {
    public:
-    Base(Next&& next)
+    explicit Base(Next&& next)
         : next_(std::forward<Next>(next)) {}
 
     void onNext(T value) override {

diff --git a/experimental/yarpl/test/Observable_test.cpp b/experimental/yarpl/test/Observable_test.cpp
@@ -383,7 +383,8 @@ TEST(Observable, DISABLED_SimpleTake) {
 }
 
 TEST(Observable, Error) {
-  auto observable = Observables::error<int>(std::runtime_error("something broke!"));
+  auto observable =
+      Observables::error<int>(std::runtime_error("something broke!"));
   auto collector = make_ref<CollectingObserver<int>>();
   observable->subscribe(collector);