Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST_N Reactive Pull Support #10

Closed
benjchristensen opened this issue Jul 27, 2015 · 3 comments
Closed

REQUEST_N Reactive Pull Support #10

benjchristensen opened this issue Jul 27, 2015 · 3 comments

Comments

@benjchristensen
Copy link
Contributor

The handler exists in the server implementation to receive the REQUEST_N messages, but it is not functioning: https://github.com/ReactiveSocket/reactivesocket-java/blob/e38b757ca02e597712139dfb9d01ba5dc7079c40/src/main/java/io/reactivesocket/ReactiveSocketServerProtocol.java#L192

Client side is sending the REQUEST_N messages: https://github.com/ReactiveSocket/reactivesocket-java/blob/e38b757ca02e597712139dfb9d01ba5dc7079c40/src/main/java/io/reactivesocket/ReactiveSocketClientProtocol.java#L132 However, the protocol design now specifies the initial request should be combined with the initial payload, and the client implementation does not do that right now. It won't be hard though once the binary encoding supports it.

@benjchristensen
Copy link
Contributor Author

(I ran out of time to get the server side REQUEST_N working. I can deal with this when I return.)

@benjchristensen
Copy link
Contributor Author

The initial requestN is also not being sent yet.

See RequesterTest.testRequestStreamSuccess for a incomplete test.

@benjchristensen
Copy link
Contributor Author

Implemented.

stevegury pushed a commit that referenced this issue Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant