-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Automatic-Module-Name #910
Comments
For now the low hanging fruit is to declare an "Automatic-Module-Name" in the MANIFEST just like Reactor and Netty have done. I propose using a filename convention which is also what Java's ModuleFinder picks by default:
I am aware of the recommendation to use reverse DNS naming based on the root package but there is quite a bit of divergence on among libraries this including Reactor which uses the filename convention and Netty which uses reverse DNS naming but based on module names rather than packages. Also modules ( |
Moving to backlog to allow more time for feedback. |
Are we happy with this approach now? Seems like something we should be doing given we are coming up to a second LTS post JDK 9 Example from okhttp as well https://github.com/square/okhttp/blob/f8fd4d08decf697013008b05ad7d2be10a648358/mockwebserver-junit4/build.gradle |
Closes rsocketgh-910 Signed-off-by: Rossen Stoyanchev <rstoyanchev@vmware.com>
This is now superseded by the actual changes in #1007. |
Closes gh-910 Signed-off-by: Rossen Stoyanchev <rstoyanchev@vmware.com>
An
Automatic-Module-Name
in the manifest of the published JAR-files would improve Java 9+ compatibility when using modules. Currently you will receive warnings about using an unstable name derived from the module's file name.Motivation
Targeting Java 9+ is becoming more common and being able to use RSocket while also using Java modules would be beneficial to those projects.
Desired solution
Set an
Automatic-Module-Name
for JARs.Considered alternatives
A full
module-info.java
for every project could also be added, but is more complicated while also keeping Java 8 support.The text was updated successfully, but these errors were encountered: