Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces use of deprecated MonoProcessor API #1003

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Replaces use of deprecated MonoProcessor API #1003

merged 1 commit into from
Apr 29, 2021

Conversation

rstoyanchev
Copy link
Contributor

No description provided.

@rstoyanchev rstoyanchev marked this pull request as draft April 20, 2021 18:24
@rstoyanchev
Replace use of deprecated Reactor Processor types
0b6ad3e 
Signed-off-by: Rossen Stoyanchev <rstoyanchev@vmware.com>
@rstoyanchev rstoyanchev marked this pull request as ready for review April 29, 2021 09:41
@rstoyanchev rstoyanchev self-assigned this Apr 29, 2021
@rstoyanchev rstoyanchev added this to the 1.1.1 milestone Apr 29, 2021
@rstoyanchev
Copy link
Contributor Author

The remaining uses of Reactor Processor in src/main are in io.rsocket.internal.UnboundedProcessor which will be done in #752 as well as in deprecated classes in rsocket-load-balancer module.

ResolvingOperatorTests did not convert easily but is due to be replaced with JC Stress tests.

TestDuplexConnection also does not convert easily. It uses DirectProcessor + FluxSink and if changed to Sinks.many().multicast().directBestEffort() + sink.asFlux(), there are failures in RSocketResponderTest in a couple of the checkNoLeaksOnRacingXxx tests. I'll need your help on the last one, @OlegDokuka.

In addition I'm not sure if the use of tryEmitNext might need more checks, in tests with Sinks.Many for example.

@rstoyanchev rstoyanchev mentioned this pull request Apr 29, 2021
Closed
@OlegDokuka OlegDokuka changed the title Replace use of deprecated Reactor Processor API replaces use of deprecated Reactor Processor API Apr 29, 2021
@OlegDokuka OlegDokuka merged commit 67f6077 into rsocket:master Apr 29, 2021
@rstoyanchev rstoyanchev linked an issue Apr 29, 2021 that may be closed by this pull request
Replace usages of Processors that were deprecated in Reactor 2020.0.0 #957
Closed
@rstoyanchev rstoyanchev deleted the processors branch May 5, 2021 14:06
@rstoyanchev rstoyanchev changed the title replaces use of deprecated Reactor Processor API Replaces use of deprecated MonoProcessor API Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
task
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Replace usages of Processors that were deprecated in Reactor 2020.0.0
2 participants
@rstoyanchev @OlegDokuka