New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduces onClose
listener for RSocketClient and connect
method
#1063
Conversation
connect
method
connect
methodonClose
listener for RSocketClient and connect
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only a couple of small comments for the connect
method, which could also be split out into a separate commit as it is orthogonal to the onClose
I think.
|
||
default boolean connect() { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should raise NotImplementedException
or not have a default implementation at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also needs Javadoc to state what it does, when this is useful vs just making requests, when it returns true vs false, and what happens for any scenarios of interest (e.g. if already connected, if already terminated, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
14fbd84
to
40e02a5
Compare
@rstoyanchev added 2 separate commits as it was suggested |
rsocket-core/src/main/java/io/rsocket/core/RSocketClientAdapter.java
Outdated
Show resolved
Hide resolved
b7b3c4a
to
d1875da
Compare
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Co-authored-by: Rossen Stoyanchev <rstoyanchev@users.noreply.github.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
d1875da
to
7502fde
Compare
closes #1048
Signed-off-by: Oleh Dokuka odokuka@vmware.com
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com