Reusable Payload
#209
Reusable Payload
#209
Conversation
| * @param singleUse {@code true} if the buffer position is to be reset on every invocation of {@link #getData()} and | ||
| * {@link #getMetadata()}. | ||
| */ | ||
| public PayloadImpl(ByteBuffer data, ByteBuffer metadata, boolean singleUse) { | ||
| this.data = data; |
There was a problem hiding this comment.
could we record the current position of the data, and the metadata and return a slice from that position instead?
There was a problem hiding this comment.
@robertroeser ByteBuffer.slice() always uses the current position i.e. there is no such method as ByteBuffer.slice(position). So, if we were to slice, we still have to reset the position first.
Do you see any other value in using slice() even though we have to reset position first?
There was a problem hiding this comment.
ping @robertroeser
NiteshKant
force-pushed
the
0.5.x-payload
branch
from
0b285cd
to
73f5802
Compare
| * @param singleUse {@code true} if the buffer position is to be reset on every invocation of {@link #getData()} and | ||
| * {@link #getMetadata()}. | ||
| */ | ||
| public PayloadImpl(ByteBuffer data, ByteBuffer metadata, boolean singleUse) { |
There was a problem hiding this comment.
nitpick: but renaming/reversing singleUse to reusable may be easier to understand (especially if you don't read the doc).
There was a problem hiding this comment.
@stevegury done, renamed to reusable and changed implementation!
|
Ping, any chance to get this in soon? :) |
__Problem__
`PayloadImpl` caches `data` and `metadata` buffers. This means once those buffers are read, they can not be reused as the pointer of `ByteBuffer` has moved to the end of buffer.
This restricts the usage of `PayloadImpl` instance with something like:
```java
socket.requestResponse(new PayloadImpl("Hello")).retry(2);
```
For any retry in the above code, data read from the payload instance will be empty.
__Modification__
- store buffer `position()` on creation and reset them on every `get()`.
- Additional constructor to override this behavior and create a payload for single use.
- `PayloadImpl` defaults to reusable payload.
__Result__
Possible to retry a request without having a custom `Payload` implementation.
NiteshKant
force-pushed
the
0.5.x-payload
branch
from
73f5802
to
6f3ad31
Compare
|
@ktoso you got it 😄 |
|
Excellent, thanks! Very nice to see much movement here in the new year 👍 |
Problem
PayloadImplcachesdataandmetadatabuffers. This means once those buffers are read, they can not be reused as the pointer ofByteBufferhas moved to the end of buffer.This restricts the usage of
PayloadImplinstance with something like:For any retry in the above code, data read from the payload instance will be empty.
Modification
position()on creation and reset them on everyget().PayloadImpldefaults to reusable payload.Result
Possible to retry a request without having a custom
Payloadimplementation.