Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Javadoc to RSocketConnector and RSocketServer #813

Merged
merged 1 commit into from May 4, 2020
Merged

Add Javadoc to RSocketConnector and RSocketServer #813

merged 1 commit into from May 4, 2020

Conversation

rstoyanchev
Copy link
Contributor

Closes #769

@rstoyanchev rstoyanchev added this to the 1.0 milestone May 4, 2020
@rstoyanchev rstoyanchev force-pushed the 769-javadoc branch 2 times, most recently from 60b05aa to 348749d Compare May 4, 2020 10:18
OlegDokuka
OlegDokuka approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left minor comment related to composite metadata

@rstoyanchev
Add Javadoc to RSocketConnector and RSocketServer
2340b33 
Closes rsocketgh-769

Signed-off-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
@rstoyanchev rstoyanchev added this to Done in Core May 4, 2020
@OlegDokuka OlegDokuka merged commit 4fa7312 into rsocket:develop May 4, 2020
@rstoyanchev rstoyanchev deleted the 769-javadoc branch May 4, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees
No one assigned
Labels
documentation
Projects
Core
  
Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Add Javadoc to RSocketFactory
2 participants
@rstoyanchev @OlegDokuka