fixes onClose behaviour to not error on shutdown #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
enhancement/on-close-2
branch
from
6e6f285
to
e837f2f
Compare
|
Thanks @OlegDokuka |
OlegDokuka
force-pushed
the
enhancement/on-close-2
branch
2 times, most recently
from
b41c63f
to
5059f51
Compare
rstoyanchev
approved these changes
May 11, 2020
OlegDokuka
force-pushed
the
enhancement/removes-error-consumer
branch
from
aa16de1
to
3656f5c
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/on-close-2
branch
from
5059f51
to
7e035bc
Compare
OlegDokuka
changed the base branch from
enhancement/removes-error-consumer
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #819
Signed-off-by: Oleh Dokuka shadowgun@i.ua