improves DuplexConnection api and reworks Resumability #923
Conversation
OlegDokuka
added
breaking changes
OlegDokuka
changed the title
rsocket-core/src/main/java/io/rsocket/internal/UnboundedProcessor.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/internal/BaseDuplexConnection.java
Show resolved
Hide resolved
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
5 times, most recently
from
7c26049
to
ac0d169
Compare
|
@rstoyanchev finalized API and reworked Resumability implementation. If API and reworked impl looks good, will be adding tests and merging |
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
ac0d169
to
fd319cc
Compare
| @@ -183,21 +183,21 @@ public InternalDuplexConnection( | |||
| } | |||
|
|
|||
| @Override | |||
| public Mono<Void> send(Publisher<ByteBuf> frame) { | |||
| public void sendFrame(int streamId, ByteBuf frame) { | |||
There was a problem hiding this comment.
I think we can remove this duplicate copy of ClientServerInputMultplexer. The class is for internal use and this copy is no longer used. I don't see much sense in a deprecation.
In addition, the ClientServerInputMultiplexerTest is still in the internal package and still references the old class which means the new one doesn't have coverage.
| return serverConnection; | ||
| } | ||
|
|
||
| public DuplexConnection asClientConnection() { | ||
| DuplexConnection asRequesterConnection() { |
There was a problem hiding this comment.
Really minor but the terminology requester and responder doesn't align with the rest of this class which is client and server, including the class name. DuplexConnectionInterceptor.Type also uses client and server, and so does the spec when describing client and server stream id's. I believe that is what they are, and this is why they flip between RSocketConnector and RSocketServer where one creates the requester asRequesterConnection() while the other with asResponderConnection().
I think asClientConnection() and asServerConnection are correct.
rsocket-core/src/main/java/io/rsocket/plugins/DuplexConnectionInterceptor.java
Show resolved
Hide resolved
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
fa944a6
to
3fe88bf
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Co-authored-by: Rossen Stoyanchev <rstoyanchev@users.noreply.github.com>
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
3fe88bf
to
ba7a04f
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
ba7a04f
to
8396d4d
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
f502089
to
545cc91
Compare
OlegDokuka
force-pushed
the
enhancement/new-duplex-connection-design
branch
from
545cc91
to
e355d53
Compare
OlegDokuka
changed the title
This PR enhances DuplexConnection API to unify the way how frames should be sent over it
Signed-off-by: Oleh Dokuka shadowgun@i.ua