Expose remote address via DuplexConnection #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Sep 10, 2020
rsocket-core/src/test/java/io/rsocket/test/util/LocalSocketAddress.java
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Sep 10, 2020
| * Return the remote address that this connection is connected to. The returned {@link | ||
| * SocketAddress} varies by transport type and should be downcast to obtain more detailed | ||
| * information. For TCP and WebSocket, the address type is {@link java.net.InetSocketAddress}. For | ||
| * local transport, it is {@link io.rsocket.transport.local.LocalSocketAddress}. |
There was a problem hiding this comment.
Can we clarify here that it is null for disconnected connections? Do we want to mark as @nullable?
There was a problem hiding this comment.
I think for a disconnected connection, the channel still returns an address. My understanding is it can return null before it is connected but DuplexConnection is typically created after the connection is established.
There was a problem hiding this comment.
Yup. I think soo. I guess once the connection is resolved, the address should be available.
Closes rsocketgh-735 Signed-off-by: Rossen Stoyanchev <rstoyanchev@vmware.com>
rstoyanchev
force-pushed
the
remote-address
branch
from
0002d67
to
2d0efed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #735 and #743.