Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanups general code and public API #175

Merged
merged 12 commits into from
Jul 21, 2021
Merged

Conversation

olme04
Copy link
Contributor

@olme04 olme04 commented Jul 15, 2021

  • revert ensures Payload released in LimitingFlowCollector #172
  • remove unused data packet from ErrorFrame
  • change Frame.type from field to getter
  • expose FrameType to public
  • cleanup usages of DangerousInternalIoApi on ChunkBuffer - after ktor 1.6.0 it's no more internal
  • move some classes to internal package
  • change visibility from public to internal for some functions and deduplicate several functions (like SafeChannel) and use hack with invisible reference to use internal declarations in other modules - TODO may be find some better way to share such internal declarations between core and TCP/WS/Local transports implementations
  • use sealed interfaces for mime-types and payload builders
  • use fun interfaces in places with suspend fun
  • make logging api explicitly public and provide temporary experimental annotation for it
  • enable explicitApi mode

@OlegDokuka OlegDokuka changed the title General code and public API Cleanup cleanups general code and public API Jul 21, 2021
@OlegDokuka OlegDokuka merged commit 4185675 into rsocket:master Jul 21, 2021
olme04 added a commit to olme04/rsocket-kotlin that referenced this pull request Jul 21, 2021
@olme04 olme04 deleted the cleanup branch July 21, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants