Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs TCP server and client transport #191

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Nodejs TCP server and client transport #191

merged 1 commit into from
Jan 12, 2022

Conversation

olme04
Copy link
Contributor

@olme04 olme04 commented Dec 9, 2021 •
edited

  • Promote example to full, but minimal configurable implementation
  • Run tests for new transport
  • Don't depend on kotlinx.nodejs
  • Support publishing plain JS module

@olme04 olme04 mentioned this pull request Dec 9, 2021
Merged
@olme04 olme04 force-pushed the task/build/3-nodejs-transport branch from 423a841 to 7e580b9 Compare December 13, 2021 12:50
@olme04 olme04 marked this pull request as ready for review December 13, 2021 12:50
@olme04 olme04 force-pushed the task/build/3-nodejs-transport branch 2 times, most recently from fec54c2 to 5025c1f Compare December 17, 2021 07:23
@olme04 olme04 force-pushed the task/build/3-nodejs-transport branch from 5025c1f to d3ad388 Compare December 17, 2021 07:29
@olme04
Copy link
Contributor Author

olme04 commented Dec 21, 2021

@OlegDokuka @yschimke PR is ready for review :)

@whyoleg whyoleg merged commit 7a9ab2e into rsocket:master Jan 12, 2022
@olme04 olme04 deleted the task/build/3-nodejs-transport branch January 12, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olme04 @whyoleg