-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gradle #38
remove gradle #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to land this into master and then rebase #29 on it since most of the changes are unrelated to #29 and im not sure when #29 will land.
Would you be able to change the PR base to master and just remove my work in progress page additions? I can worry about rebasing #29 onto master after that.
On second thought I'll make the changes to remove my work in-progress page. Should be minimal change, then we can change the PR base to master. |
flatten directories move content into content- folders update documentation based on changes
a8af9ac
to
8882039
Compare
use https for css.link
fix URL to be DEPLOY_URL
missed moving svgs in rebase
This is now ready for review again. I believe when it lands in |
add minimum netlify.toml
TODO: @flyinprogrammer needs to fix this because it's all garbage once we start using Netlify. | ||
Starting with the fact that PROJECT_BASE_URL will likely become DEPLOY_URL from Netlify, but | ||
what will that value be for contributors or people who want to fork ¯\_(ツ)_/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO
now complete that we have netlify setup or still an open item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really i was waiting for things to roll on to master so i could then use the fork->PR process to fix it 😂
flatten directories
move content into content- folders
update documentation based on changes