Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gradle #38

Merged
merged 24 commits into from
Mar 2, 2021
Merged

remove gradle #38

merged 24 commits into from
Mar 2, 2021

Conversation

flyinprogrammer
Copy link
Collaborator

flatten directories

move content into content- folders

update documentation based on changes

Copy link
Member

@viglucci viglucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to land this into master and then rebase #29 on it since most of the changes are unrelated to #29 and im not sure when #29 will land.

Would you be able to change the PR base to master and just remove my work in progress page additions? I can worry about rebasing #29 onto master after that.

@viglucci
Copy link
Member

viglucci commented Mar 2, 2021

On second thought I'll make the changes to remove my work in-progress page. Should be minimal change, then we can change the PR base to master.

@viglucci
Copy link
Member

viglucci commented Mar 2, 2021

On second thought I'll make the changes to remove my work in-progress page. Should be minimal change, then we can change the PR base to master.

Addressed here: #40.

If we land that then we can land this in master without worrying about #29 while its in-progress.

@flyinprogrammer flyinprogrammer changed the base branch from feature/getting-started-docs to master March 2, 2021 14:51
@flyinprogrammer flyinprogrammer changed the base branch from master to feature/getting-started-docs March 2, 2021 14:52
@flyinprogrammer flyinprogrammer changed the base branch from feature/getting-started-docs to master March 2, 2021 14:54
missed moving svgs in rebase
@flyinprogrammer
Copy link
Collaborator Author

This is now ready for review again. I believe when it lands in master the Github Action will work correctly and publish the site.

Comment on lines +41 to +43
TODO: @flyinprogrammer needs to fix this because it's all garbage once we start using Netlify.
Starting with the fact that PROJECT_BASE_URL will likely become DEPLOY_URL from Netlify, but
what will that value be for contributors or people who want to fork ¯\_(ツ)_/¯
Copy link
Member

@viglucci viglucci Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO now complete that we have netlify setup or still an open item?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really i was waiting for things to roll on to master so i could then use the fork->PR process to fix it 😂

@viglucci viglucci merged commit b020760 into master Mar 2, 2021
@viglucci viglucci deleted the feature/no-mo-gradle branch July 28, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants