Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change application reserved error code range #184

Merged
merged 3 commits into from Mar 1, 2017
Merged

Change application reserved error code range #184

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff5973f
Change application reserved error code range
lexs Feb 22, 2017
773e1f0
Update Protocol.md
lexs Feb 23, 2017
88ca73d
Update Protocol.md
lexs Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Protocol.md
View file
Open in desktop
Expand Up @@ -349,7 +349,7 @@ The Error Data is typically an Exception message, but could include stringified
| __RESERVED__ | 0xFFFFFFFF | __Reserved for Extension Use__ |

__NOTE__: Values in the range of 0x0001 to 0x00FF are reserved for use as SETUP error codes. Values in the range of
0x00101 to 0x001FF are reserved for connection error codes. Values in the range of 0x00201 to 0xFFFFFFFE are reserved for application layer
0x00101 to 0x001FF are reserved for connection error codes. Values in the range of 0x00205 to 0xFFFFFFFE are reserved for application layer
Copy link
Member

@yschimke yschimke Feb 22, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intent was that errors were in distinct blocks, somewhat like 2XX, 3XX, 4XX, 5XX in HTTP.

So your suggestion to go to 0x300 seems like the only sensible approach. Although should probably be 0x301 as we skip X00 for all other ranges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x301 seems good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. 0x301.

errors.

<a name="frame-lease"></a>
Expand Down