Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib #21

Merged
merged 13 commits into from
Jun 2, 2018
Merged

Matplotlib #21

merged 13 commits into from
Jun 2, 2018

Conversation

davidmascharka
Copy link
Collaborator

@davidmascharka davidmascharka commented Feb 7, 2018

This adds a section on matplotlib covering everything listed in #15:

  • fig/ax
  • Plotting in notebook mode
  • Basic plotting, color, linestyle, labels, titles
  • Error-bar plots, fill_between
  • Multiple plots in a figure, multiple plots on an axis
  • Plotting images
  • Saving figures

Scoping and organization may need some work @rsokl

Link to the rendered notebook

@davidmascharka davidmascharka mentioned this pull request Feb 7, 2018
14 tasks
@davidmascharka
Copy link
Collaborator Author

The file is too large for me to make changes/view diffs on GitHub, so I took a look at the changes locally. This looks way better! Here are a couple small modifications (no line numbers because they probably wouldn't help anyway):

  • Matplotlib section, first paragraph: natively uses two- and three-dimensional <-- add a hyphen to "two"

  • Same section and paragraph: "This section will instroduce the basics of plotting and key..."

  • Same: "Consult the matplotlib users guide

  • Matplotlib section, last paragraph: you writh mathplotlib <- change to matplotlib

  • Plotting in Jupyter Notebooks section: "interact with the plots the render within" should be "interact with the plots that render within"

  • Creating Figures and Axes with pyplot.subplots section, first paragraph: "figsize can be used to control the size of the figure, which the keyword arguments..." should be "figsize can be used to control the size of the figure, while the keyword arguments..."

  • Axes object section where you lay out all the different plots: "The matrice's entries" should be "matrix entries" or "matrix's entrys" since it's a single matrix, not multiple matrices.

Additional note: You might clean up the file by getting rid of the [<matplotlib.lines>] objects that print, just so it looks neater.

@rsokl
Copy link
Owner

rsokl commented Feb 11, 2018

Awesome! Thanks for looking at this. Still working on it. Writing about matplotlib is so boring

@rsokl
Copy link
Owner

rsokl commented May 28, 2018

@davidmascharka I think this is good to go! We're on a roll! Would you mind taking a look?

@davidmascharka davidmascharka self-assigned this May 28, 2018
@davidmascharka
Copy link
Collaborator Author

I'm so sad my cool color-gradient image is gone 😢

I think this all looks good. Is imread going in somewhere else? I noticed it got taken out.

@rsokl
Copy link
Owner

rsokl commented May 29, 2018

haha I'm so sorry. The color gradient example was just way to intellectually demanding for the purpose it was serving :P

Ah I totally didn't mean to get rid of imread !

@rsokl rsokl merged commit fbe7cf2 into master Jun 2, 2018
@rsokl rsokl deleted the matplotlib branch June 2, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants