Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate brackets and braces in both classifiers #10

Closed
V0ldek opened this issue Sep 15, 2022 · 0 comments · Fixed by #127
Closed

Differentiate brackets and braces in both classifiers #10

V0ldek opened this issue Sep 15, 2022 · 0 comments · Fixed by #127
Assignees
@V0ldek
Labels
area: selector Support for a JSONPath selector good first issue Good for newcomers help wanted External contributions welcome type: feature New feature or request
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Sep 15, 2022

Is your feature request related to a problem? Please describe.
Currently the classifier returns Opening and Closing tokens regardless of whether it is a brace or a bracket. For some selectors it is required to know whether we are in a list or an object, so these should be differentiated.

Describe the solution you'd like
Split the two variants into ObjectOpening/ObjectClosing and ListOpening/ListClosing. This doesn't require changes to any SIMD machinery. Current engines need to be updated to react to both kinds of events.
@V0ldek V0ldek added type: feature New feature or request help wanted External contributions welcome good first issue Good for newcomers acceptance: go ahead Reviewed, implementation can start labels Sep 15, 2022
@V0ldek V0ldek assigned V0ldek and unassigned V0ldek Sep 15, 2022
@V0ldek V0ldek mentioned this issue Sep 15, 2022
Closed
@V0ldek V0ldek changed the title Differentiate brackets and braces in both classifiers. Differentiate brackets and braces in both classifiers Sep 15, 2022
@V0ldek V0ldek added this to the v1.0.0 milestone Sep 15, 2022
@V0ldek V0ldek added mod: engine area: selector Support for a JSONPath selector labels Nov 23, 2022
@V0ldek V0ldek self-assigned this Apr 16, 2023
V0ldek added a commit that referenced this issue Apr 16, 2023
@V0ldek
feat: Structural split for brace and bracket
272771a 
Instead of `Opening` and `Closing` we now have `OpeningBrace`, `OpeningBracket`, `ClosingBrace`, `ClosingBracket`.

Ref: #10
@V0ldek V0ldek mentioned this issue Apr 16, 2023
Merged
3 tasks
V0ldek added a commit that referenced this issue Apr 19, 2023
@V0ldek
lib: switch Structural to BracketType
2b03e8d 
The `Opening` and `Closing` variants now differentiate between curly
and square brackets with a value of the `BracketType` enum.

Ref: #10
V0ldek added a commit that referenced this issue Apr 19, 2023
@V0ldek
Merge pull request #127 from V0ldek/v0ldek/#10-differentiate-braces-a…
ff2196c 
…nd-brackets

Differentiate braces and brackets in structural classification
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
area: selector Support for a JSONPath selector good first issue Good for newcomers help wanted External contributions welcome type: feature New feature or request
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Differentiate braces and brackets in structural classification rsonquery/rsonpath
1 participant
@V0ldek