[Fix] Set loaded variable explicitly

rspamd · Nov 13, 2023 · b661260 · b661260
1 parent 0be20c4
commit b661260
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/libmime/lang_detection_fasttext.cxx b/src/libmime/lang_detection_fasttext.cxx
@@ -40,7 +40,7 @@ class fasttext_langdet {
 private:
 	fasttext::FastText ft;
 	std::string model_fname;
-	bool loaded;
+	bool loaded = false;
 
 public:
 	explicit fasttext_langdet(struct rspamd_config *cfg)
@@ -124,10 +124,11 @@ class fasttext_langdet {
 		return predictions;
 	}
 
-	auto model_info(void) const -> std::string
+	auto model_info(void) const -> const std::string
 	{
 		if (!loaded) {
-			return "fasttext model is not loaded";
+			static const auto not_loaded = std::string{"fasttext model is not loaded"};
+			return not_loaded;
 		}
 		else {
 			return fmt::format("fasttext model {}: {} languages, {} tokens", model_fname,