[Fix] Symcache: Do not use C style comparators in C++ sorts

rspamd · Jun 28, 2022 · ca367c4 · ca367c4
1 parent cbdb219
commit ca367c4
Showing 1 changed file with 4 additions and 18 deletions.
diff --git a/src/libserver/symcache/symcache_impl.cxx b/src/libserver/symcache/symcache_impl.cxx
@@ -96,25 +96,11 @@ auto symcache::init() -> bool
 	}
 
 	/* Sorting stuff */
-	auto postfilters_cmp = [](const auto &it1, const auto &it2) -> int {
-		if (it1->priority > it2->priority) {
-			return 1;
-		}
-		else if (it1->priority == it2->priority) {
-			return 0;
-		}
-
-		return -1;
+	constexpr auto postfilters_cmp = [](const auto &it1, const auto &it2) -> bool {
+		return it1->priority < it2->priority;
 	};
-	auto prefilters_cmp = [](const auto &it1, const auto &it2) -> int {
-		if (it1->priority > it2->priority) {
-			return -1;
-		}
-		else if (it1->priority == it2->priority) {
-			return 0;
-		}
-
-		return 1;
+	constexpr auto prefilters_cmp = [](const auto &it1, const auto &it2) -> bool {
+		return it1->priority > it2->priority;
 	};
 
 	msg_debug_cache("sorting stuff");