Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build of 3.7.4 fails on FreeBSD #4702

Open
yasuhirokimura opened this issue Nov 14, 2023 · 9 comments
Open

[BUG] Build of 3.7.4 fails on FreeBSD #4702

yasuhirokimura opened this issue Nov 14, 2023 · 9 comments
Labels

Comments

@yasuhirokimura
Copy link

I'm trying to update FreeBSD Rspamd port to 3.7.4.

https://github.com/yasuhirokimura/freebsd-ports/tree/rspamd/mail/rspamd

But build fails with following error.

ld.lld: error: src/librspamd-server.so: undefined reference to rspamd_hyperscan_notice_loaded [--no-allow-shlib-undefined]
c++: error: linker command failed with exit code 1 (use -v to see invocation)

Full build log:
https://people.freebsd.org/~yasu/poudriere/data/logs/bulk/132amd64-default-rspamd/2023-11-15_04h12m23s/logs/rspamd-3.7.4.log

@sthen
Copy link
Contributor

sthen commented Nov 15, 2023

Builds OK with hyperscan enabled, but not otherwise. This is basically a dup of #4701

@vstakhov
Copy link
Member

In fact, you should not use Rspamd without hyperscan. I'll probably fix that issue but in future I plan to make Hyperscan dependency mandatory.

@vstakhov
Copy link
Member

I'm trying to update FreeBSD Rspamd port to 3.7.4.

Let's probably hold on till 3.7.5

bob-beck pushed a commit to openbsd/ports that referenced this issue Nov 15, 2023
upstream says "in future I plan to make Hyperscan dependency mandatory"
(rspamd/rspamd#4702 (comment))
so I've removed the separate hyperscan flavour and rolled it into the
main package - this restricts archs to amd64 for now - if someone wants
to run this on aarch64 then porting vectorscan is an option, but others
e.g. sparc64 won't be supported.
vstakhov added a commit that referenced this issue Nov 15, 2023
@yasuhirokimura
Copy link
Author

In fact, you should not use Rspamd without hyperscan. I'll probably fix that issue but in future I plan to make Hyperscan dependency mandatory.

IIUC hyperscan works only with x86_64/amd64. Do you mean you will make Rspamd work only with the architecture too?

@yasuhirokimura
Copy link
Author

Let's probably hold on till 3.7.5

By applying d907a95 build scceeds without hyperscan.
Thanks for quick fix!

@arkamar
Copy link
Contributor

arkamar commented Nov 18, 2023

@vstakhov do you plan to release 3.7.5 soon or should I backport the commit to Gentoo. There is a related bug reported in Gentoo bugzilla, see https://bugs.gentoo.org/917512.

@vstakhov
Copy link
Member

The only thing that blocks me from 3.7.5 is #4703 I cannot reproduce this issue anywhere but it seems to be quite bad for many people.

@arkamar
Copy link
Contributor

arkamar commented Nov 18, 2023

Ok, I'll wait a bit more, thanks for fast response!

@timtas
Copy link

timtas commented Nov 25, 2023

In fact, you should not use Rspamd without hyperscan. I'll probably fix that issue but in future I plan to make Hyperscan dependency mandatory.

Why not? Is it really that much faster, e.g. is rspamd unusable without it?

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Dec 3, 2023
The issue is fixed with a patch backported from upstream.

Upstream-issue: rspamd/rspamd#4701
Upstream-issue: rspamd/rspamd#4702
Closes: https://bugs.gentoo.org/917512
Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
fatalbanana pushed a commit to fatalbanana/rspamd that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants