Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bayes_expiry.conf to provide ability to set custom settings #4972

Merged
merged 4 commits into from
May 18, 2024

Conversation

dragoangel
Copy link
Contributor

No description provided.

@moisseev
Copy link
Member

In my opinion, there's no necessity to redefine module defaults. Instead, I suggest commenting parameters out and leaving them as examples.

Short comments on their meanings would be useful as well. ;)

@dragoangel
Copy link
Contributor Author

I just do it same way I see it in other modules, it has a place in other conf. Also maybe instead of adding comments I better expand rspamd docs?

@dragoangel
Copy link
Contributor Author

Removed settings duplication. Will create PR to docs separately

@dragoangel
Copy link
Contributor Author

dragoangel commented May 17, 2024

@moisseev rspamd/rspamd.com#748 please check, if this is okay, can you approve\merge both PRs please?

@dragoangel
Copy link
Contributor Author

dragoangel commented May 17, 2024

@vstakhov can we merge this please to allow users to adjust bayes expiry settings? I also found out that cluster_nodes is obsolite but wasn't removed after efe8fd4 PR from other parts of the script. I think we can remove them to no create confusion from:

I not sure, but I have feeling that before switching to LUA based scripts bayes expiry could process mail with default settings, but after switching to LUA - default count of 1000 is not enough, at least this was the case in my case. I had to increase count in 15 times, but by default we can think about setting 2000 as example?

@vstakhov vstakhov merged commit c8ba300 into rspamd:master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants