-
-
Notifications
You must be signed in to change notification settings - Fork 763
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add better error message when shared context is missing
- Closes #432.
- Loading branch information
1 parent
1dae214
commit 9e94666
Showing
2 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e94666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hesitant to merge this in because we currently "get" shared example groups from two different locations, so I think there should be a method for both. Here is the other location:
https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/example_group.rb#L68-72
9e94666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that should be covered as well. @slawosz - you want to take a crack at that?
9e94666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinko, @dchelimsky i will deal with it.
9e94666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slawosz thanks for offering to do this, but I went ahead and did it myself since I saw how I wanted it to work: 940f7fe