Add seed section into JSON formatter #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, I could have sworn we already did this. LGTM, thanks for contribution! Looks like some of the build failures are relevant due to line number shifting in the spec files(!?) There has to be a better way... |
|
Thanks for your review. I'll try fix specs. |
[1, *[2, 3], *[4, 5]] is syntax error in Ruby1.8
takkanm
force-pushed
the
add_seed_section_into_json_formatter
branch
from
d96352d
to
292a07f
Compare
|
I fixed CI failure. How about this? |
|
Great! Thanks. |
|
Thank you!! |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
* add seed information to json output
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to seed infomation in JSON output. Because, current RSpec default order option is rand.