New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit a warning for around(:context)
#2687
Conversation
aa884c3
to
8c6ff23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6672089
to
9d54bbb
Compare
👍 |
Emit a warning for `around(:context)`
One thing confusing about this warning is that it points to something that isn't literally
|
As
|
Sure, I'm not saying that it's incorrect, just confusing. |
We can probably move this warning deeper, to @shepmaster Would you want to tackle that? |
Thank you for the offer, but it seems unlikely I'll have the time for it 😿. We only had one case of this warning so my specific pain has passed. I mostly thought to post this in case other people have the same pain, or if y'all start getting a lot of reports. |
Emit a warning for `around(:context)`
…-context-warning Emit a warning for `around(:context)` --- This commit was imported from rspec/rspec-core@36c5ad5.
fixes #2486
related to #1031