Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec makes define_method public? #873

Merged
merged 3 commits into from
Apr 18, 2013
Merged

RSpec makes define_method public? #873

merged 3 commits into from
Apr 18, 2013

Commits on Apr 18, 2013

  1. test that we dont leak define_method into public methods

    @JonRowe
    JonRowe committed Apr 18, 2013
    Configuration menu
    Copy the full SHA
    fbc33d6 View commit details
    Browse the repository at this point in the history

  2. No longer make define_method public, use send instead. 

    MemoizedHelpers::ClassMethods module was making define_method
public for ease of use within the module. No longer do this and
use send instead. This fixes #873.
    @JonRowe
    Thomas Holmes authored and JonRowe committed Apr 18, 2013
    Configuration menu
    Copy the full SHA
    4d3a64d View commit details
    Browse the repository at this point in the history

  3. update changelog

    @JonRowe
    JonRowe committed Apr 18, 2013
    Configuration menu
    Copy the full SHA
    cdeb6ef View commit details
    Browse the repository at this point in the history