Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of warnings from rspec-core's library and spec code. #909

Merged
merged 7 commits into from May 16, 2013

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented May 15, 2013

Extension of #907 with some refactorings

@phiggins
Copy link
Contributor

Heh, I figured somebody would know how to do this better than I could. Thanks for taking this to the finish line!

@JonRowe
Copy link
Member Author

JonRowe commented May 16, 2013

Not better, just different... my reasoning for pp is that I'd rather hide the warnings that pp generates, given it's a Ruby issue not an RSpec one rather than monkey patching the test. The other tweak is that warning's aren't necessarily enabled (although we do recommend them be on) so I'd rather preserve the original state afterwards.

JonRowe added a commit that referenced this pull request May 16, 2013
Get rid of warnings from rspec-core's library and spec code.
@JonRowe JonRowe merged commit 7ea8ca7 into rspec:master May 16, 2013
@JonRowe JonRowe deleted the silence_warnings branch May 16, 2013 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants