The top-level Rakefile requires Bundler awareness. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the bin/rake Bundler binstub, the binstub sets ENV['BUNDLE_GEMFILE'] which is inherited by calls to the rake environments of the Projects. The top level Gemfile only includes Rake and Thor, so it's not surprising that the builds can't continue. MRI 1.9.2 appears to be able to work around this with "export RUBYOPT=rubygems", but that seems inelegant at best. This change determines if the Rakefile was launched through a bundled rake; if so, it uses Bundler.with_clean_env (and deletes the BUNDLE_GEMFILE for good measure; necessary if you use the binstub, less necessary if you use "bundle exec rake") and instead of running 'rake', it runs 'bin/rake' to force the use of the Project rake binstub, forcing the use of the correct Gemfile and bundler environment. The non-bundler path works as it always has.
|
See Issue #21 |
|
👍 |
justinko
added a commit
that referenced
this pull request
Mar 13, 2012
The top-level Rakefile requires Bundler awareness.
|
Thanks @halostatue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the bin/rake Bundler binstub, the binstub sets ENV['BUNDLE_GEMFILE'] which is inherited by calls to the rake environments of the Projects. The top level Gemfile only includes Rake and Thor, so it's not surprising that the builds can't continue. MRI 1.9.2 appears to be able to work around this with "export RUBYOPT=rubygems", but that seems inelegant at best.
This change determines if the Rakefile was launched through a bundled rake; if so, it uses Bundler.with_clean_env (and deletes the BUNDLE_GEMFILE for good measure; necessary if you use the binstub, less necessary if you use "bundle exec rake") and instead of running 'rake', it runs 'bin/rake' to force the use of the Project rake binstub, forcing the use of the correct Gemfile and bundler environment.
The non-bundler path works as it always has.