Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby3 preview1 to build matrix with allow_failures #249

Merged
merged 1 commit into from Sep 26, 2020

Conversation

benoittgt
Copy link
Member

Hello

https://www.ruby-lang.org/en/news/2020/09/25/ruby-3-0-0-preview1-released/
I choose to be very explicit. rvm use 3.0.0-preview1 was not working, rvm use 3 yes but I think we should be explicit when we speak about version. :)

Have a nice evening

@JonRowe JonRowe merged commit 98c7fa4 into main Sep 26, 2020
@JonRowe JonRowe deleted the add-ruby-3-preview1 branch September 26, 2020 07:29
@JonRowe
Copy link
Member

JonRowe commented Sep 26, 2020

Beat me to it! I'd like to get this out of allow-failures as soon as possible, but that might be a job for RSpec 4.

@JonRowe
Copy link
Member

JonRowe commented Sep 26, 2020

Do you want to run the PR generator?

@benoittgt
Copy link
Member Author

Beat me to it! I'd like to get this out of allow-failures as soon as possible, but that might be a job for RSpec 4.

I would love too! 😄

@benoittgt
Copy link
Member Author

benoittgt commented Sep 27, 2020

Ok I failed and run the command for plain text files too. That explain the amount of closed pull request.

I pushed two change directly on master that where not committed here.

  • diff-lcs change d97105d
  • and main branch definition on travis file b522283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants