Start switching to Github Actions for CI #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Nov 16, 2020
| @@ -0,0 +1,35 @@ | |||
| name: RSpec CI | |||
| on: [pull_request, push] | |||
There was a problem hiding this comment.
I believe this needs to be tweaked so we only run push on main/*-maintenance/*-dev
There was a problem hiding this comment.
Something like? I am not sur for pull_request.
on:
# Trigger the workflow on push or pull request,
# but only for the main branch
push:
branches:
- main
- *-maintenance
- *-dev
pull_request:
branches:
- **
benoittgt
reviewed
Nov 16, 2020
| - 2.1.9 | ||
| - ruby-head | ||
| fail-fast: false | ||
| continue-on-error: ${{ matrix.ruby == 'jruby-9.2.13.0' || endsWith(matrix.ruby, 'head') }} |
There was a problem hiding this comment.
head at least is needed post 3.0.0's release, and the jruby one is needed until its fixed
|
@JonRowe @benoittgt We have this left: Are we moving those to GHA? I've missed your |
|
@pirj yes when I figure it out 😂 |
|
Windows is coming in hot though 🔥 |
|
🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.