Skip to content

Commit

Permalink
Fix confusing error message in be_within
Browse files Browse the repository at this point in the history
This is a patch for the following issue:

#92

It is possible to have duck typing for numerical operations, but the minus
sign is often used for other operations as well such as the set
difference that Array#- performs. In that case, even if it does not fail
on the :- method, it will probably fail on the subsequent :abs and :<=
calls.
  • Loading branch information
zhangsu committed May 17, 2012
1 parent 5626043 commit 675115d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/rspec/matchers/built_in/be_within.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ def matches?(actual)
unless defined?(@expected)
raise ArgumentError.new("You must set an expected value using #of: be_within(#{delta}).of(expected_value)")
end
unless actual.is_a? Numeric
raise ArgumentError, "Expected a numeric value be within #{delta} of #{expected} but got #{actual.inspect}"
end
(super(actual) - expected).abs <= delta
end

Expand Down
4 changes: 4 additions & 0 deletions spec/rspec/matchers/be_within_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ module Matchers
matcher = be_within(0.5)
expect { matcher.matches?(5.1) }.to raise_error(ArgumentError, /must set an expected value using #of/)
end

it "raises an error if the actual value is not numeric" do
expect { be_within(0.1).of(0).matches?(nil) }.to raise_error(ArgumentError, /Expected a numeric value be within/)
end
end
end
end

0 comments on commit 675115d

Please sign in to comment.