Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ruby < 2.3 support #1231

Merged
merged 13 commits into from Dec 12, 2020
Merged

Drop Ruby < 2.3 support #1231

merged 13 commits into from Dec 12, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Nov 23, 2020 •
edited

@pirj pirj self-assigned this Nov 23, 2020
@pirj pirj force-pushed the drop-old-rubies branch 2 times, most recently from 83ed8fc to 29ccd62 Compare November 28, 2020 19:20
This was referenced Nov 29, 2020
Merged
Merged
Merged
Closed
@pirj pirj changed the title [Don't review just yet] Remove Ruby < 2.3 support Remove Ruby < 2.3 support Dec 8, 2020
@pirj pirj changed the title Remove Ruby < 2.3 support Drop Ruby < 2.3 support Dec 8, 2020
@pirj pirj force-pushed the drop-old-rubies branch 2 times, most recently from 3bce576 to 0422c6a Compare December 9, 2020 22:39
@pirj pirj marked this pull request as ready for review December 9, 2020 22:47
pirj
pirj commented Dec 9, 2020
View reviewed changes
maintenance-branch Outdated Show resolved Hide resolved
JonRowe
JonRowe reviewed Dec 10, 2020
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
JonRowe
JonRowe requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @pirj, just a few things to put back and a few questions.

@pirj pirj force-pushed the drop-old-rubies branch 3 times, most recently from 7060305 to 3ff3dd2 Compare December 12, 2020 12:19
@pirj
Copy link
Member Author

pirj commented Dec 12, 2020

Updates:

  • reverted jruby_version usages
  • pinned ffi to ~> 1.12.0
  • added Changelog entry under "Breaking changes"
  • removed MatchData wrapper

@pirj pirj requested a review from JonRowe December 12, 2020 13:17
JonRowe
JonRowe requested changes Dec 12, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a couple more things

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
cucumber.yml Outdated Show resolved Hide resolved
lib/rspec/matchers/built_in/count_expectation.rb Outdated Show resolved Hide resolved
@pirj pirj requested a review from JonRowe December 12, 2020 16:00
@JonRowe JonRowe merged commit a147a45 into 4-0-dev Dec 12, 2020
@JonRowe JonRowe deleted the drop-old-rubies branch December 12, 2020 18:37
@pirj pirj restored the drop-old-rubies branch December 14, 2020 17:15
@pirj
Copy link
Member Author

pirj commented Dec 14, 2020

Restored the branch, rspec-support depends on it.

@pirj pirj deleted the drop-old-rubies branch December 15, 2020 08:36
@pirj pirj mentioned this pull request Dec 18, 2020
Open
53 tasks
@pirj pirj added this to the 4.0 milestone Dec 25, 2020
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
@JonRowe
[expectations] Merge pull request rspec/rspec-expectations#1231 from …
92a4be4 
…rspec/drop-old-rubies

Drop Ruby < 2.3 support

---
This commit was imported from rspec/rspec-expectations@a147a45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt Awaiting requested review from benoittgt

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pirj @JonRowe